fix: label premium features in middleware error #14360
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Emyrk
approved these changes
Aug 19, 2024
|
Thank you for confirming! I added a test as well, to mirror the one we have for custom roles. Did some brief smoke testing as well. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Emyrk is this verbiage correct? Currently in the frontend I am naming the license as "premium", distinct from "enterprise", so I wanted to update the backend error message as well, but if this is wrong let me know and I will change the frontend too.
The capitalization seems weird to me, but keeping it since it was already there.
Cleanup item for #13915