fix(cli): ensure that the support bundle command does not panic on zero values #14392
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtojek
approved these changes
Aug 22, 2024
Just a testing gap, to be honest. |
dannykopping
approved these changes
Aug 22, 2024
cli/support_test.go
Outdated
| assert.NoError(t, json.NewEncoder(w).Encode(resp)) | ||
| default: | ||
| // Simply return a 200 OK for everything else. | ||
| w.WriteHeader(http.StatusOK) |
There was a problem hiding this comment.
Would a non-200 response also trigger this problem?
For example:
eg.Go(func() error {
hr, err := healthsdk.New(client).DebugHealth(ctx)
if err != nil {
return xerrors.Errorf("fetch health report: %w", err)
}
d.HealthReport = &hr
return nil
})I think it might be more idiomatic to have all calls fail rather than return empty values, although both are worthwhile testing.
There was a problem hiding this comment.
That's a good point, I'll test against a range of status codes. 👍
Co-authored-by: Danny Kopping <danny@coder.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We try to write a cute little summary at the end of the bundle, but that could panic if some of the fields of the bundle were nil. Adds a test that essentially ensures nil values in a bundle, and ensures that it can be handled without losing our towels.