fix: cli: prettify schedule when printing output #1440
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1440 +/- ##
==========================================
+ Coverage 67.10% 67.12% +0.01%
==========================================
Files 291 291
Lines 19527 19557 +30
Branches 258 258
==========================================
+ Hits 13104 13127 +23
- Misses 5073 5081 +8
+ Partials 1350 1349 -1
Continue to review full report at Codecov.
|
| @@ -49,9 +49,18 @@ func Weekly(spec string) (*Schedule, error) { | |||
| return nil, xerrors.Errorf("expected *cron.SpecSchedule but got %T", specSched) | |||
| } | |||
|
|
|||
| tz := "UTC" | |||
There was a problem hiding this comment.
I think this is a bit brittle. The CLI will always pass a schedule string that starts with CRON_TZ=, but if someone sets a schedule through the API, it could be any valid string that the parser will accept. And if the schedule doesn't include a timezone, it will be interpreted using the server's timezone, which could be different from UTC.
There was a problem hiding this comment.
Good point. Defaulting CRON_TZ=UTC is probably the simplest way here.
| if strings.HasPrefix(raw, "CRON_TZ=") { | ||
| tz = strings.TrimPrefix(strings.Fields(raw)[0], "CRON_TZ=") | ||
| cron = strings.Join(strings.Fields(raw)[1:], " ") | ||
| } |
There was a problem hiding this comment.
It really bothers me that we have to do this using direct string manipulation instead of just looking at the parsed schedule, but it doesn't seem like this cron library provides a better way 😞
* Adds methods to schedule.Schedule to show the raw cron string and timezone * Uses these methods to clean up output of auto(start|stop) show or ls * Defaults CRON_TZ=UTC if not provided
Ref: #1431 (comment)
This PR does the following:
schedule.Scheduleto show the raw cron string and timezoneauto(start|stop) showorlsCRON_TZ=UTCif not provided