fix: filter "add group member" by organization #14404
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
code-asher
commented
Aug 22, 2024
8b7185d to
49a709f
Compare
This is accomplished by using the members endpoint instead of the users endpoint, and to that end the UserAutocomplete component has been reworked to support either endpoint as separate components with a shared base.
49a709f to
60e165c
Compare
BrunoQuaresma
approved these changes
Aug 23, 2024
|
Fair, let me add one on the group page. |
This ensures it is using the right endpoint for the add member dropdown.
824b581 to
fd02c23
Compare
|
@BrunoQuaresma I added a Storybook testing the integration but do you know if there is a way to mock errors with react-query? I see we use I could also split it off into a view and then test that instead. |
|
I figured out a way to do it, but let me know if there is a better way |
0bfabe0 to
fe2f523
Compare
fe2f523 to
a043653
Compare
|
@code-asher it looks good enough for me 🚢 it |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is accomplished by using the members endpoint instead of the users endpoint, and to that end the UserAutocomplete component has been reworked to support either endpoint as separate components with a shared base.
This only affects the group page under organizations, the original one (which shows when the multi-org experiment is disabled) remains unaffected. The org group page dropdown should now only show users belonging to the organization instead of all the users in the deployment.
Closes #13915