chore: implement generalized symmetric difference for set comparison #14407
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Going to be used in Organization Sync + maybe group sync. Felt better to reuse, rather than copy
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Symmetric difference in set theory is used to determine which elements need to be added/removed to go from set
Ato setB. We use this atm when determining which roles are added/removed when changing a user's permissions.This same logic can be applied to organization sync (WIP) and group sync (WIP). Felt better to just make it a generalized slice function. This code is slightly less efficient since a map was used before for membership, but the slices we are working with are small anyway.