Skip to content

fix(coderd/database/dbmem): include a technical summary row on over-pagination #14415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 23, 2024
Merged

fix(coderd/database/dbmem): include a technical summary row on over-pagination #14415

merged 1 commit into from
Aug 23, 2024

Conversation

johnstcn
Copy link
Member

Fixes an error when over-paginating with dbmem:

GET  http://localhost:41311/api/v2/workspaces?limit=100&offset=100&q=name%3A%22scaletest-%22+template%3A%22friendly-goldwasser8-gOF%22: unexpected status code 500: Internal error fetching workspaces.
Error: Workspace summary row is missing.

@johnstcn johnstcn self-assigned this Aug 23, 2024
@johnstcn johnstcn requested a review from mtojek August 23, 2024 12:02
mtojek
mtojek approved these changes Aug 23, 2024
View reviewed changes
Copy link
Member

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stamp 👍

@johnstcn johnstcn merged commit d4adfa3 into main Aug 23, 2024
28 checks passed
@johnstcn johnstcn deleted the cj/dbmem/workspace-summary-row branch August 23, 2024 12:16
@github-actions github-actions bot locked and limited conversation to collaborators Aug 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mtojek mtojek mtojek approved these changes

Assignees

@johnstcn johnstcn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johnstcn @mtojek