fix: Remove CSS overrides for material-ui #1444
Conversation
This hopefully removes some debt, and doesn't mess up styling too much!
Codecov Report
@@ Coverage Diff @@
## main #1444 +/- ##
==========================================
+ Coverage 67.10% 67.12% +0.01%
==========================================
Files 291 290 -1
Lines 19527 19518 -9
Branches 258 256 -2
==========================================
- Hits 13104 13101 -3
+ Misses 5073 5070 -3
+ Partials 1350 1347 -3
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
This breaks a few things, and I feel that it overlaps with #803 (TL:DR - Adjusting the theme to be dark only, including adjustments that are needed in all pages/components).
Since there's a lot of pieces here, and it's not on CE scope to remove the overrides, I suggest we use the chromatic build here as a reference point and hand-off to @Kira-Pilot for #803 and its concerns.
The goal can be to solve these incrementally (whether it's with #803 or after, so as to avoid doubling up on style work or creating conflict) for minimal risk.
I captured these thoughts in #1449
Going to go ahead and put my name on that one. |
|
This is done as part of the redesign in #1450! |
|
Superseded by #1450 |
This hopefully removes some debt, and doesn't mess up
styling too much!