Skip to content

feat: show organization name for groups on user profile #14448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Aug 29, 2024
Merged

feat: show organization name for groups on user profile #14448

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
e000bd1
feat: show organization name for groups on user profile
aslilac Aug 26, 2024
164f8d6
sqlc.embed
aslilac Aug 27, 2024
013b422
hmm
aslilac Aug 27, 2024
f3373d8
Merge branch 'main' into user-groups-with-org-display-name
aslilac Aug 27, 2024
b5424ad
tada
aslilac Aug 27, 2024
d0cf454
somethin'
aslilac Aug 27, 2024
90643b5
fix entities
aslilac Aug 27, 2024
ab2658f
bruh just do it then
aslilac Aug 27, 2024
2b231a5
what
aslilac Aug 27, 2024
7f147fc
fix dbmem impl
aslilac Aug 27, 2024
98e249d
🧹
aslilac Aug 27, 2024
360d1a1
Merge branch 'main' into user-groups-with-org-display-name
aslilac Aug 28, 2024
181a120
mhm
aslilac Aug 28, 2024
4447c81
update groupsByOrganization endpoint
aslilac Aug 28, 2024
d460922
get rid of `GroupWithOrganizationInfo` type
aslilac Aug 28, 2024
c7a6ce8
fix mom
aslilac Aug 28, 2024
5422157
fix id
aslilac Aug 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix dbmem impl
  • Loading branch information
@aslilac
aslilac committed Aug 27, 2024
commit 7f147fc25e3fd45ddc76d5631f3071c51800cdc5
17 changes: 12 additions & 5 deletions coderd/database/dbmem/dbmem.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2609,6 +2609,10 @@
return int64(len(users)), nil
}

type GetGroupsCachedOrganizationDetails struct {
name, displayName string

Check failure on line 2613 in coderd/database/dbmem/dbmem.go

View workflow job for this annotation

GitHub Actions / lint 

field `name` is unused (unused)
}

func (q *FakeQuerier) GetGroups(_ context.Context, arg database.GetGroupsParams) ([]database.GetGroupsRow, error) {
err := validateDatabaseType(arg)
if err != nil {
Expand All @@ -2634,7 +2638,7 @@
}
}

organizationDisplayNames := make(map[uuid.UUID]string)
organizationDisplayNames := make(map[uuid.UUID]struct{ name, displayName string })
filtered := make([]database.GetGroupsRow, 0)
for _, group := range q.groups {
if arg.OrganizationID != uuid.Nil && group.OrganizationID != arg.OrganizationID {
Expand All @@ -2646,20 +2650,23 @@
continue
}

orgDisplayName, ok := organizationDisplayNames[group.ID]
orgDetails, ok := organizationDisplayNames[group.ID]
if !ok {
for _, org := range q.organizations {
if group.OrganizationID == org.ID {
orgDisplayName = org.DisplayName
orgDetails = struct{ name, displayName string }{
name: org.Name, displayName: org.DisplayName,
}
break
}
}
organizationDisplayNames[group.ID] = orgDisplayName
organizationDisplayNames[group.ID] = orgDetails
}

filtered = append(filtered, database.GetGroupsRow{
Group: group,
OrganizationDisplayName: orgDisplayName,
OrganizationName: orgDetails.name,
OrganizationDisplayName: orgDetails.displayName,
})
}

Expand Down
Loading