Skip to content

fix: error when clicking on login screen #1445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 14, 2022
Merged

fix: error when clicking on login screen #1445

merged 1 commit into from
May 14, 2022

Conversation

greyscaled
Copy link
Contributor

Resolves: #1435

@greyscaled greyscaled requested a review from a team as a code owner May 13, 2022 23:20
@greyscaled greyscaled self-assigned this May 13, 2022
@codecov
Copy link

codecov bot commented May 13, 2022

Codecov Report

Merging #1445 (de0afdf) into main (50ad2f8) will increase coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1445      +/-   ##
==========================================
+ Coverage   67.10%   67.14%   +0.04%     
==========================================
  Files         291      292       +1     
  Lines       19527    19591      +64     
  Branches      258      258              
==========================================
+ Hits        13104    13155      +51     
- Misses       5073     5084      +11     
- Partials     1350     1352       +2     
Flag Coverage Δ
unittest-go-macos-latest 54.36% <ø> (+0.06%) ⬆️
unittest-go-postgres- 65.59% <ø> (+0.08%) ⬆️
unittest-go-ubuntu-latest 56.58% <ø> (+0.03%) ⬆️
unittest-go-windows-2022 52.70% <ø> (+0.04%) ⬆️
unittest-js 74.73% <ø> (ø)
Impacted Files Coverage Δ
site/src/components/SignInForm/SignInForm.tsx 100.00% <ø> (ø)
provisionersdk/serve.go 35.13% <0.00%> (-8.11%) ⬇️
cli/cliui/provisionerjob.go 76.42% <0.00%> (-2.15%) ⬇️
peer/conn.go 79.85% <0.00%> (-1.97%) ⬇️
provisionerd/provisionerd.go 77.37% <0.00%> (-0.14%) ⬇️
cli/templates.go 100.00% <0.00%> (ø)
cli/templatedelete.go 62.50% <0.00%> (ø)
coderd/templates.go 64.43% <0.00%> (+0.18%) ⬆️
coderd/provisionerdaemons.go 63.81% <0.00%> (+0.50%) ⬆️
agent/agent.go 67.14% <0.00%> (+0.61%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50ad2f8...de0afdf. Read the comment docs.

@greyscaled greyscaled merged commit e061715 into main May 14, 2022
@greyscaled greyscaled deleted the vapurrmaid/1435 branch May 14, 2022 00:07
@misskniss misskniss added this to the V2 Beta milestone May 15, 2022
kylecarbs pushed a commit that referenced this pull request Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Usability: clicking anywhere on login screen except email field spawns an email error message
3 participants