Skip to content

feat: improve custom roles create/edit page #14456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 28, 2024
Merged

feat: improve custom roles create/edit page #14456

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
49f9157
fix: improve show/hide checkbox text
jaaydenh Aug 22, 2024
800a49e
feat: add parent checkbox for grouped resource permissions
jaaydenh Aug 27, 2024
31b89e4
fix: align action list item to a grid
jaaydenh Aug 27, 2024
0ecf024
chore: add additional tests
jaaydenh Aug 28, 2024
14ae89d
fix: format
jaaydenh Aug 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: align action list item to a grid
  • Loading branch information
@jaaydenh
jaaydenh committed Aug 27, 2024
commit 31b89e4d9634f25d44732b438b7a10f275c4d720
11 changes: 8 additions & 3 deletions site/src/pages/ManagementSettingsPage/CustomRolesPage/CreateEditRolePageView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -346,7 +346,7 @@ const PermissionCheckboxGroup: FC<PermissionCheckboxGroupProps> = ({
{resourceKey}
<ul css={styles.checkBoxes}>
{Object.entries(value).map(([actionKey, value]) => (
<li key={actionKey}>
<li key={actionKey} css={styles.actionItem}>
<span css={styles.actionText}>
<Checkbox
size="small"
Expand All @@ -357,8 +357,8 @@ const PermissionCheckboxGroup: FC<PermissionCheckboxGroupProps> = ({
onChange={(e) => handleActionCheckChange(e, form)}
/>
{actionKey}
</span>{" "}
&ndash; <span css={styles.actionDescription}>{value}</span>
</span>
<span css={styles.actionDescription}>{value}</span>
</li>
))}
</ul>
Expand Down Expand Up @@ -412,7 +412,12 @@ const styles = {
}),
actionDescription: (theme) => ({
color: theme.palette.text.secondary,
paddingTop: 6,
}),
actionItem: {
display: "grid",
gridTemplateColumns: "270px 3fr",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ultra nit: this could be 1fr since there aren't any other columns taking fractions

},
} satisfies Record<string, Interpolation<Theme>>;

export default CreateEditRolePageView;
Loading