Skip to content

Add monitoring package #1446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 10 commits into from
Closed
Prev Previous commit
Next Next commit
Remove resource type and name from monitoring
  • Loading branch information
code-asher committed May 18, 2022
commit f7784bbb2aa0cbd2bc7499f57223f3dae5a0728e
2 changes: 0 additions & 2 deletions coderd/monitoring/monitoring.go
Original file line number Diff line number Diff line change
Expand Up @@ -104,8 +104,6 @@ func New(ctx context.Context, options *Options) *Monitor {
Name: "workspace_resources",
Help: "The workspace resources in a Coder deployment.",
}, []string{
"workspace_resource_id",
"workspace_resource_name",
"workspace_resource_type",
}),
},
Expand Down
3 changes: 1 addition & 2 deletions coderd/monitoring/monitoring_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -127,8 +127,7 @@ func TestMonitoring(t *testing.T) {
name: "coder_workspace_resources",
total: 2,
labels: []labels{
{name: "workspace_resource_name", value: "banana2"},
{name: "workspace_resource_name", value: "banana3"},
{name: "workspace_resource_type", value: "google_compute_instance"},
},
},
}
Expand Down