fix: wait for provisioner daemon jobs to finish after sigterm #14466
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14433.
The function for shutting down a provisioner daemon has the signature:
The
coder server
code for handling graceful provisioner shutdowns was correct:Whilst the matching code for graceful shutdowns of independent provisioner daemons (
coder provisionerd start
) was not:This wasn't caught by tests as I don't believe we have any clitests for
provisionerd
. The existing tests call the shutdown function directly.