fix: prevent notifier test flakiness #14467
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes coder/internal#281
There was a TOCTOU race between checking whether the notifier should pause and processing the messages:
I'm of the opinion that we don't need to fix this in the code itself (it's not super critical that pausing the notifier is effected immediately); it was just a problem for the tests.
Previously in the tests:
process
method) <-- TOCTOUNow:
process
method exits