chore: add organization search query to workspaces #14474
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f0ssel
approved these changes
Aug 28, 2024
| @@ -95,7 +75,7 @@ func Users(query string) (database.GetUsersParams, []codersdk.ValidationError) { | |||
| return filter, parser.Errors | |||
| } | |||
|
|
|||
| func Workspaces(query string, page codersdk.Pagination, agentInactiveDisconnectTimeout time.Duration) (database.GetWorkspacesParams, []codersdk.ValidationError) { | |||
| func Workspaces(ctx context.Context, db database.Store, query string, page codersdk.Pagination, agentInactiveDisconnectTimeout time.Duration) (database.GetWorkspacesParams, []codersdk.ValidationError) { | |||
There was a problem hiding this comment.
aside: I see why we do it in this package, but this is kind of a weird naming scheme for something that returns database query params.
There was a problem hiding this comment.
Fair. Maybe it should be named WorkspacesFilter or something. I won't address here though
Comment on lines
+273
to
+277
| db := dbmem.New() | ||
| if c.Setup != nil { | ||
| c.Setup(t, db) | ||
| } | ||
| values, errs := searchquery.Workspaces(context.Background(), db, c.Query, codersdk.Pagination{}, 0) |
There was a problem hiding this comment.
Can we not use the traditional way of getting a DB in tests so this can run against postgres too?
There was a problem hiding this comment.
I'd prefer not to for this. What would be even better is if I used the mock database, but I haven't messed with that at all yet.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #14444