Skip to content

chore: replace AlecAivazis/survey with charmbracelet/bubbletea #14475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 28 commits into from
Sep 4, 2024
Merged

chore: replace AlecAivazis/survey with charmbracelet/bubbletea #14475

Changes from 1 commit
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
3934cb6
chore: replace survery library with bubbletea
DanielleMaywood Aug 29, 2024
164402b
chore: fix nolint comments
DanielleMaywood Aug 29, 2024
360fb95
chore: add message and colour to select prompts
DanielleMaywood Aug 29, 2024
7cf35d1
chore: make SelectedOptions private
DanielleMaywood Aug 29, 2024
b5092a6
chore: add filtering for multiselect, improve filtering algo
DanielleMaywood Aug 29, 2024
e4c010e
chore: allow vertical wrap on select/multiselect
DanielleMaywood Aug 29, 2024
2b6cd6e
chore: fix failing jobs
DanielleMaywood Aug 29, 2024
35fe461
chore: update charmbracelet/bubbletea to v1.0.0
DanielleMaywood Aug 29, 2024
5982185
chore: remove windows testing workaround for survey library
DanielleMaywood Aug 29, 2024
affbfbe
chore: update bubbletea to v1.1.0
DanielleMaywood Sep 2, 2024
33196cd
chore: reimplement testing workaround
DanielleMaywood Sep 2, 2024
409cec5
chore: use survey's default page size
DanielleMaywood Sep 2, 2024
52ed127
chore: ensure no underflow on page bottom
DanielleMaywood Sep 2, 2024
60c83d0
chore: remove multi-select test from cmd/cliui
DanielleMaywood Sep 3, 2024
2b621ce
chore: disable HideSearch from cmd/cliui select
DanielleMaywood Sep 3, 2024
8a3cd26
chore: use strings.Builder, fix select all logic, apply nitpicks
DanielleMaywood Sep 3, 2024
6e59ecb
chore: use strings.Builder
DanielleMaywood Sep 3, 2024
579c73b
chore: move m.search.Update out of case
DanielleMaywood Sep 3, 2024
9078242
chore: use tea.WithContext(inv.Context()) for tea program
DanielleMaywood Sep 3, 2024
f2ed4fa
chore: return nil as err already handled
DanielleMaywood Sep 3, 2024
7784110
chore: use const instead of magic number
DanielleMaywood Sep 3, 2024
f598836
chore: handle signals ourself instead of bubbletea
DanielleMaywood Sep 3, 2024
8a7f1bc
chore: update flake.nix
DanielleMaywood Sep 4, 2024
77804e0
chore: update flake.nix
DanielleMaywood Sep 4, 2024
2904b7c
chore: update flake.nix
DanielleMaywood Sep 4, 2024
0b99afe
chore: update flake.nix
DanielleMaywood Sep 4, 2024
b173fb0
chore: update flake.nix
DanielleMaywood Sep 4, 2024
966f772
chore: update flake.nix
DanielleMaywood Sep 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: ensure no underflow on page bottom
  • Loading branch information
@DanielleMaywood
DanielleMaywood committed Sep 4, 2024
commit 52ed1278479a30536d3513de9bdc3b4be2bb791c
4 changes: 2 additions & 2 deletions cli/cliui/select.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,10 +219,10 @@ func (m selectModel) viewableOptions() ([]string, int) {
case m.cursor <= halfHeight:
top = min(top, m.height)
case m.cursor < top-halfHeight:
bottom = m.cursor - halfHeight
bottom = max(0, m.cursor-halfHeight)
top = min(top, m.cursor+halfHeight+1)
default:
bottom = top - m.height
bottom = max(0, top-m.height)
}

return options[bottom:top], bottom
Expand Down