Skip to content

chore: match templates search error with workspace search error #14479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 30, 2024

Conversation

Emyrk
Copy link
Member

@Emyrk Emyrk commented Aug 29, 2024

Closes #14384

The table loading happens the same on workspaces. So better to keep it consistent.

Screencast.from.2024-08-29.10-05-02.webm

@Emyrk Emyrk changed the title chore: make templates search error the same as workspaces chore: match templates search error with workspace search error Aug 29, 2024
@Emyrk Emyrk requested a review from aslilac August 29, 2024 21:05
Copy link
Member

@aslilac aslilac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@Emyrk
Copy link
Member Author

Emyrk commented Aug 30, 2024

@Emyrk Emyrk merged commit 0ef8514 into main Aug 30, 2024
27 of 28 checks passed
@Emyrk Emyrk deleted the stevenmasley/template_search branch August 30, 2024 20:15
@github-actions github-actions bot locked and limited conversation to collaborators Aug 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cannot search template name with spaces
2 participants