Skip to content

fix: serve test derp map locally #14490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 30, 2024
Merged

fix: serve test derp map locally #14490

merged 1 commit into from
Aug 30, 2024

Conversation

ethanndickson
Copy link
Member

@ethanndickson ethanndickson commented Aug 30, 2024 •
edited
Loading

Fixes #14395

Stacked as CI would not otherwise pass until #14489 is merged.

@ethanndickson Graphite App
Copy link
Member Author

ethanndickson commented Aug 30, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @ethanndickson and the rest of your teammates on Graphite Graphite

@ethanndickson ethanndickson marked this pull request as ready for review August 30, 2024 06:31
dannykopping
dannykopping approved these changes Aug 30, 2024
View reviewed changes
Copy link
Contributor

@dannykopping dannykopping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ethanndickson ethanndickson force-pushed the 08-30-fix_serve_test_derp_map_locally branch from 3773ec1 to 386b1b0 Compare August 30, 2024 06:36
@ethanndickson ethanndickson changed the base branch from main to 08-30-fix_delete_workspace_agent_stats_after_180_days August 30, 2024 06:36
This was referenced Aug 30, 2024
Merged
Merged
@ethanndickson ethanndickson changed the base branch from 08-30-fix_delete_workspace_agent_stats_after_180_days to graphite-base/14490 August 30, 2024 08:30
@ethanndickson ethanndickson force-pushed the 08-30-fix_serve_test_derp_map_locally branch from 386b1b0 to 86e280f Compare August 30, 2024 08:30
@ethanndickson ethanndickson changed the base branch from graphite-base/14490 to main August 30, 2024 08:31
@ethanndickson ethanndickson merged commit 851df91 into main Aug 30, 2024
34 of 53 checks passed
@ethanndickson Graphite App
Copy link
Member Author

Merge activity

@ethanndickson ethanndickson deleted the 08-30-fix_serve_test_derp_map_locally branch August 30, 2024 08:43
@github-actions github-actions bot locked and limited conversation to collaborators Aug 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dannykopping dannykopping dannykopping approved these changes

Assignees

@ethanndickson ethanndickson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

flake: TestServer_DisabledDERP
2 participants
@ethanndickson @dannykopping