Skip to content

fix: allow posting licenses that will be valid in future #14491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

spikecurtis
Copy link
Contributor

@spikecurtis spikecurtis commented Aug 30, 2024

relates to #14476

Fixes our license POST handler such that you can post a license that isn't yet valid, but will be in the future. Previously we rejected such requests; c.f. the linked issue for context.

Copy link
Contributor Author

spikecurtis commented Aug 30, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @spikecurtis and the rest of your teammates on Graphite Graphite

@spikecurtis spikecurtis requested review from Emyrk and johnstcn August 30, 2024 08:00
@spikecurtis spikecurtis marked this pull request as ready for review August 30, 2024 08:00
Copy link
Member

@Emyrk Emyrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took a look at the JWT flow to make sure that error does not short circuit anything.

Nifty approach to returning multiple errors 👍

@spikecurtis spikecurtis merged commit 5bd5801 into main Sep 3, 2024
32 checks passed
Copy link
Contributor Author

Merge activity

@spikecurtis spikecurtis deleted the spike/14476-post-license branch September 3, 2024 05:09
@github-actions github-actions bot locked and limited conversation to collaborators Sep 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants