chore(dogfood): optimize dockerfile for envbuilder cache probing #14497
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
172bc8d to
c8b1add
Compare
c8b1add to
e4fae2f
Compare
deansheather
approved these changes
Aug 30, 2024
dogfood/contents/Dockerfile
Outdated
| ARG GOPATH="/tmp/" | ||
| RUN mkdir --parents "$GOPATH" && \ | ||
| # Install Go utilities. | ||
| RUN apt-get install --yes gcc && \ |
There was a problem hiding this comment.
You should still just merge the gcc with the curl apt install above to save build time
There was a problem hiding this comment.
It can help cache utilization for when a Go tool version changes, but beyond that I don't see how there would be an improvement in build time?
Installing and uninstalling is a significant size optimization though:
sha256:ef2ad8c02872f01a9e71fc56afdf2ecda2a3d827ac61f5a9e1be0b096b79c335 About a minute ago RUN /bin/sh -c apt-get install gcc --yes # buildkit 159MB buildkit.dockerfile.v0
There was a problem hiding this comment.
This is install+cleanup:
sha256:b39c284ff9fac0da7a256f29de3116c5109f4f04e12291ded468314dde50b28a 19 seconds ago RUN /bin/sh -c apt-get install gcc --yes && apt-get remove --yes gcc && apt-get autoremove --yes && apt-get clean # buildkit 1.64MB buildkit.dockerfile.v0
I thought apt-get update was pretty innocent but it's actually 50MB too. 😅
johnstcn
approved these changes
Aug 30, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR optimizes our dogfood
Dockerfilefor envbuilder caching/cache probing by reducing layer sizes and fixing an incompatible instruction.