-
Notifications
You must be signed in to change notification settings - Fork 899
feat: Redesign workspaces page #1450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 8 commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
1a667d9
feat: Improve navbar to be more compact
kylecarbs dc47ae0
Attempt to remove overrides
kylecarbs c34ad45
Update theme
kylecarbs 104b1d9
Add text field
kylecarbs 52a4e76
Merge branch 'main' into workspacepage
kylecarbs 83397e0
Update theme to dark!
kylecarbs d19c124
Fix import ordering
kylecarbs db820ce
Fix page location
kylecarbs 851111b
Fix requested changes
kylecarbs 190b7d1
Add storybook for workspaces page view
kylecarbs cbc1015
Add empty view
kylecarbs 169d733
Add tests for empty view
kylecarbs 53781e9
Remove templates page
kylecarbs f606a51
Merge branch 'main' into workspacepage
kylecarbs 09ce0ec
Fix local port
kylecarbs 71bf439
Remove templates from nav
kylecarbs 82641ab
Fix e2e test
kylecarbs 82cdace
Remove time.ts
kylecarbs 6044d91
Remove dep
kylecarbs bd50c9f
Merge branch 'main' into workspacepage
kylecarbs 191c9d7
Add background color to margins
kylecarbs fccacfe
Merge status checking from workspace page
kylecarbs f87c8e7
Fix requested changes
kylecarbs a058b8c
Fix workspace status tests
kylecarbs File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -21,10 +21,15 @@ export const NavbarView: React.FC<NavbarViewProps> = ({ user, onSignOut, display | |
<nav className={styles.root}> | ||
<List className={styles.fixed}> | ||
<ListItem className={styles.item}> | ||
<NavLink className={styles.logo} to="/"> | ||
<NavLink className={styles.logo} to="/workspaces"> | ||
kylecarbs marked this conversation as resolved.
Show resolved
Hide resolved
|
||
<Logo fill="white" opacity={1} width={125} /> | ||
</NavLink> | ||
</ListItem> | ||
<ListItem button className={styles.item}> | ||
<NavLink className={styles.link} to="/workspaces"> | ||
Workspaces | ||
</NavLink> | ||
</ListItem> | ||
<ListItem button className={styles.item}> | ||
<NavLink className={styles.link} to="/templates"> | ||
Templates | ||
|
@@ -47,13 +52,13 @@ const useStyles = makeStyles((theme) => ({ | |
justifyContent: "center", | ||
alignItems: "center", | ||
height: navHeight, | ||
background: theme.palette.navbar.main, | ||
background: theme.palette.background.paper, | ||
marginTop: 0, | ||
transition: "margin 150ms ease", | ||
"@media (display-mode: standalone)": { | ||
borderTop: `1px solid ${theme.palette.divider}`, | ||
}, | ||
borderBottom: `1px solid #383838`, | ||
borderBottom: `1px solid ${theme.palette.divider}`, | ||
}, | ||
fixed: { | ||
flex: 0, | ||
|
@@ -68,9 +73,9 @@ const useStyles = makeStyles((theme) => ({ | |
display: "flex", | ||
height: navHeight, | ||
paddingLeft: theme.spacing(4), | ||
paddingRight: theme.spacing(2), | ||
paddingRight: theme.spacing(4), | ||
"& svg": { | ||
width: 125, | ||
width: 109, | ||
}, | ||
}, | ||
title: { | ||
|
@@ -98,17 +103,16 @@ const useStyles = makeStyles((theme) => ({ | |
"&.active": { | ||
position: "relative", | ||
color: theme.palette.primary.contrastText, | ||
fontWeight: "bold", | ||
|
||
"&::before": { | ||
content: `"{"`, | ||
left: 10, | ||
position: "absolute", | ||
}, | ||
|
||
"&::after": { | ||
content: `"}"`, | ||
content: `" "`, | ||
bottom: 0, | ||
left: theme.spacing(3), | ||
background: "#C16800", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is there a good theme color that could go here in place of the hardcoded color? Like |
||
right: theme.spacing(3), | ||
height: 2, | ||
position: "absolute", | ||
right: 10, | ||
}, | ||
}, | ||
}, | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion: Can you pin this dependency to
4.5.9
? You run theupgrade
command to do it:There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vapurrmaid I notice we have
yarn.lock
- what's the thought process behind pinning dependencies?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll answer those two questions separately:
vs
For the former: We have a RFC and guide covering, but the TL:DR is more incremental upgrades w depend-a-bot
For the latter: I don't know if having them unpinned interferes with depend-a-bot or any other tool, but simply for precision. I shouldn't have to hunt down the actual version in
yarn.lock
to answer what version of X we're on.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, will look at the guide!