-
Notifications
You must be signed in to change notification settings - Fork 894
feat: turn off notification via email #14520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 4 commits
8568812
5309f0a
254f4dc
f9ac6d2
18b3f9a
8538ec4
025c633
8af93fd
7f0a831
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I need to remember to check for the following scenarios:
You can check how we do that using Storybook interaction tests on the There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I have verified these scnearios There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @joobisb can you add a test please? Manual verification is good but it only helps us know if this works currently, and doesn't catch future degradations. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @joobisb we are close, we just need to automate these tests using the way I shared before. Thanks for your hard work! 🙏 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @BrunoQuaresma the tests needed to be added to There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
done, please have a look |
Uh oh!
There was an error while loading. Please reload this page.