Skip to content

fix: CreateWorkspaceForm name validation #1453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 16, 2022
Merged

fix: CreateWorkspaceForm name validation #1453

merged 2 commits into from
May 16, 2022

Conversation

greyscaled
Copy link
Contributor

@greyscaled greyscaled commented May 14, 2022 •
edited
Loading

Resolves: #1421

  • adjust getFormHelpers to allow helperText
  • refactor CreateWorkspaceForm to have Language, remove FormTextField and meet conventions
  • add missing validations to Workspace name
  • make Workspace name auto-focused

validation

greyscaled added 2 commits May 14, 2022 15:35
@greyscaled
refactor: allow helperText in getFormHelpers
eeb29ca 
By passing in helperText, we will not accidentally overwrite it.
@greyscaled
fix: CreateWorkspaceForm name validation
438f498 
Resolves: #1421
@greyscaled greyscaled self-assigned this May 14, 2022
@greyscaled greyscaled requested a review from a team as a code owner May 14, 2022 15:42
@misskniss misskniss added this to the V2 Beta milestone May 15, 2022
presleyp
presleyp approved these changes May 16, 2022
View reviewed changes
Copy link
Contributor

@presleyp presleyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I don't know how (if?) we're going to extend the validation from the name field to the arbitrary fields but it's nice to get things in order in advance of that at least.

@greyscaled greyscaled merged commit 9d4182b into main May 16, 2022
@greyscaled greyscaled deleted the vapurrmaid/gh-1421/username-validation branch May 16, 2022 19:30
@greyscaled greyscaled mentioned this pull request May 23, 2022
Closed
kylecarbs pushed a commit that referenced this pull request Jun 10, 2022
@greyscaled @kylecarbs
fix: CreateWorkspaceForm name validation (#1453)
ca72c6a 
* refactor: allow helperText in getFormHelpers

By passing in helperText, we will not accidentally overwrite it.

* fix: CreateWorkspaceForm name validation

Resolves: #1421
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@presleyp presleyp presleyp approved these changes

@Kira-Pilot Kira-Pilot Kira-Pilot approved these changes

Assignees

@greyscaled greyscaled

Labels
None yet
Projects
None yet
Milestone
V2 Beta
Development

Successfully merging this pull request may close these issues.

UI: Entering an invalid a Workspace Name in Create returns no error
4 participants
@greyscaled @presleyp @Kira-Pilot @misskniss