Skip to content

fix(site): only show method warning if some template is using it #14565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Sep 6, 2024
Merged

fix(site): only show method warning if some template is using it #14565

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
a602c72
Fix lint error
BrunoQuaresma Sep 4, 2024
f58660e
Extract notification events to its own component
BrunoQuaresma Sep 4, 2024
8ac097c
Merge branch 'main' of https://github.com/coder/coder into bq/notific…
BrunoQuaresma Sep 4, 2024
20ccc3f
Only show alert if templates has the method enabled
BrunoQuaresma Sep 4, 2024
c4d4afb
Fix fmt
BrunoQuaresma Sep 4, 2024
f54c435
Apply fixes and improvements suggested by @dannykopping
BrunoQuaresma Sep 6, 2024
8cf8478
Update site/src/pages/DeploySettingsPage/NotificationsPage/Notificati…
BrunoQuaresma Sep 6, 2024
db9c136
Update storybookUtils.ts
BrunoQuaresma Sep 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Fix lint error
  • Loading branch information
@BrunoQuaresma
BrunoQuaresma committed Sep 4, 2024
commit a602c72f1c7d55bea0c20341d77c262796bef2be
6 changes: 5 additions & 1 deletion site/src/pages/DeploySettingsPage/NotificationsPage/NotificationsPage.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,11 @@ export const Toggle: Story = {
const user = userEvent.setup();
const canvas = within(canvasElement);
const option = await canvas.findByText("Workspace Marked as Dormant");
const toggleButton = within(option.closest("li")!).getByRole("button", {
const li = option.closest("li");
if(!li) {
throw new Error("Could not find li");
}
const toggleButton = within(li).getByRole("button", {
name: "Webhook",
});
await user.click(toggleButton);
Expand Down