feat: notifications: report failed workspace builds #14571
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Alright, I addressed most of the feedback. Important changes:
|
dannykopping
approved these changes
Sep 17, 2024
| delay = 15 * time.Minute | ||
| ) | ||
|
|
||
| func NewReportGenerator(ctx context.Context, logger slog.Logger, db database.Store, enqueuer notifications.Enqueuer, clk quartz.Clock) io.Closer { |
There was a problem hiding this comment.
What is not tested using the current approach is exclusive locking, and this will be hard.
What makes this particularly hard (asking for real, not rhetorically)? To me it seems like we'd need to invoke NewReportGenerator in two separate goroutines and just ensure that we only get what we're expecting, which you've implemented in other tests.
I think it's quite risky to have functionality which should be guarding against pathological behaviour which is not covered by a test.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: coder/internal#40
This PR introduces support for email reports, including a report with failed workspace builds. A report generator runs periodically to see if users expect a new report. Once the report is successfully generated and spread, a record (or records) are logged in the database table.
In the multi-instance setup, report generators use an exclusive locking mechanism to ensure only one instance is running.