Skip to content

test(site): move users page test to storybook #14579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Sep 6, 2024
Merged

test(site): move users page test to storybook #14579

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
219716d
Fix lint
BrunoQuaresma Sep 5, 2024
34d2ddd
Add storybook for UsersPage
BrunoQuaresma Sep 5, 2024
782e2c0
Add suspending test
BrunoQuaresma Sep 5, 2024
a1bb0dd
Add delete user story
BrunoQuaresma Sep 5, 2024
822a2c1
Add remaining storybook tests for the user page
BrunoQuaresma Sep 5, 2024
5170f79
Remove jest test because it is covered by user page stories
BrunoQuaresma Sep 5, 2024
3c24b45
Remove unused import and console
BrunoQuaresma Sep 5, 2024
868c981
Fix fragment warning inside of menu
BrunoQuaresma Sep 5, 2024
b326df9
Simplify code
BrunoQuaresma Sep 5, 2024
9cc602c
Solve refetch warnings
BrunoQuaresma Sep 5, 2024
fa4cd29
Fix and suggestions by @code-asher
BrunoQuaresma Sep 6, 2024
fd7b5e2
Fix fmt
BrunoQuaresma Sep 6, 2024
76b4fa0
Fix test
BrunoQuaresma Sep 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix fragment warning inside of menu
  • Loading branch information
@BrunoQuaresma
BrunoQuaresma committed Sep 5, 2024
commit 868c981b5f200c44c8c763e68b6f8351d0580b0c
30 changes: 15 additions & 15 deletions site/src/components/Filter/filter.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -294,21 +294,21 @@ const PresetMenu: FC<PresetMenuProps> = ({
</MenuItem>
))}
{learnMoreLink && (
<>
<Divider css={{ borderColor: theme.palette.divider }} />
<MenuItem
component="a"
href={learnMoreLink}
target="_blank"
css={{ fontSize: 13, fontWeight: 500 }}
onClick={() => {
setIsOpen(false);
}}
>
<OpenInNewOutlined css={{ fontSize: "14px !important" }} />
View advanced filtering
</MenuItem>
</>
<Divider css={{ borderColor: theme.palette.divider }} />
)}
{learnMoreLink && (
<MenuItem
component="a"
href={learnMoreLink}
target="_blank"
css={{ fontSize: 13, fontWeight: 500 }}
onClick={() => {
setIsOpen(false);
}}
>
<OpenInNewOutlined css={{ fontSize: "14px !important" }} />
View advanced filtering
</MenuItem>
)}
{learnMoreLink2 && learnMoreLabel2 && (
<MenuItem
Expand Down