feat: group provisioners by authentication method #14580
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Parkreiner
reviewed
Sep 17, 2024
| type, | ||
| provisioners, | ||
| }) => { | ||
| const [provisioner] = provisioners; |
There was a problem hiding this comment.
Should there be a check to make sure that the provisioners array isn't empty, or is that basically guaranteed not to happen?
If there are multiple provisioners, is there anything implied by the order they appear in? As in, is the first provisioner always the "main" one?
There was a problem hiding this comment.
currently, it should never be passed an empty provisioners array, but I'm gonna refactor this to make it nicer.
site/src/pages/ManagementSettingsPage/OrganizationProvisionersPageView.stories.tsx
Show resolved
Hide resolved
site/src/pages/ManagementSettingsPage/OrganizationProvisionersPageView.tsx
Show resolved
Hide resolved
Parkreiner
approved these changes
Sep 17, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #14459