Skip to content

fix: analyze build times over 30 days not 30 months #14584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

dannykopping
Copy link
Contributor

We use the template build times to give users an estimate of how long their builds are likely to take.

This code is supposed to look back 30 days to find the p50 and p95 build times but instead it's currently looking back 30 months, which will skew the data.

Signed-off-by: Danny Kopping <danny@coder.com>
@dannykopping dannykopping requested a review from ammario September 6, 2024 14:34
@dannykopping dannykopping marked this pull request as ready for review September 6, 2024 14:58
Copy link

@cdr-bot cdr-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is a hotfix and has been automatically approved.

  • ✅ Base is main or release branch
  • ✅ Has hotfix label
  • ✅ Head is from coder/coder
  • ✅ Less than 100 lines

Copy link
Member

@Emyrk Emyrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lol, @johnstcn this is why I dislike AddDate 😆

@dannykopping dannykopping merged commit 8b1c46f into main Sep 6, 2024
30 checks passed
@dannykopping dannykopping deleted the dk/build-times-period branch September 6, 2024 15:03
@github-actions github-actions bot locked and limited conversation to collaborators Sep 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants