Skip to content

fix: increase text contrast for 'create workspace' button #14588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

Parkreiner
Copy link
Member

@Parkreiner Parkreiner commented Sep 6, 2024

Quick hotfix because some of our interactive elements werent' high-contrast enough. They're essentially the "primary action"s of their page, so it seemed better to increase the contrast, not just for accessibility, but also to help guide the eye a little bit better.

Changes made

  • Increased text contract for the "Create workspace" buttons in the /templates route

Before:
Screenshot 2024-09-05 at 10 58 13 PM

After:
Screenshot 2024-09-05 at 10 58 36 PM

Notes

  • We previously had a text color shift on hover, but even after fiddling with different transition values, I couldn't figure out a way to make sure it doesn't look janky. Just decided to remove it entirely

@Parkreiner Parkreiner self-assigned this Sep 6, 2024
Copy link

@cdr-bot cdr-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is a hotfix and has been automatically approved.

  • ✅ Base is main or release branch
  • ✅ Has hotfix label
  • ✅ Head is from coder/coder
  • ✅ Less than 100 lines

@Parkreiner Parkreiner added the site Area: frontend dashboard label Sep 6, 2024
@Parkreiner Parkreiner merged commit 0d60566 into main Sep 6, 2024
37 checks passed
@Parkreiner Parkreiner deleted the mes/create-workspace-contrast branch September 6, 2024 17:15
@github-actions github-actions bot locked and limited conversation to collaborators Sep 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
site Area: frontend dashboard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant