Skip to content

chore: update workspaces top bar to display org name #14596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Sep 16, 2024
Merged

Conversation

Parkreiner
Copy link
Member

@Parkreiner Parkreiner commented Sep 6, 2024

Part 1/3 for #14435
Won't be merging in until all parts are approved.

Changes made

All changes apply to the /:user/:workspace-name/ route.

  • Updated all quota logic to use the new quota API endpoint
  • Moved the workspace schedule controls to the right of the top bar
  • Turned quota text into a link that takes a user to the /workspaces route with the search filter pre-populated with organization from the previous page
  • Updated all breadcrumb elements to use the nicer, more detailed tooltip style
  • Updated all breadcrumb segments to have a maximum width (main text gets truncated if the text length is too long, but the tooltips always display the full name)

Bonus

  • Refactored the breadcrumbs into separate components to make the main top bar definition a little easier to read
  • Fixed an accidental render mutation that crept through a previous review

Screenshots

Screenshot 2024-09-09 at 12 52 10 PM . Screenshot 2024-09-09 at 12 49 07 PM . Screenshot 2024-09-09 at 12 50 20 PM

Notes

  • We are definitely getting to the point where that top bar has too much stuff being squeezed into a single row. Kira confirmed that visual redesigns were out of scope, but I tried to define things to minimize the risks of content overflowing or breaking

@Parkreiner Parkreiner self-assigned this Sep 6, 2024
@Parkreiner Parkreiner requested a review from jaaydenh September 9, 2024 16:56
</>
)}
</div>
{!isImmutable && (
Copy link
Member Author

@Parkreiner Parkreiner Sep 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All that changed was that, with WorkspaceScheduleControls moving to the right of the screen, I can now have everything grouped under a single check of the immutable variable

So the parent <div> got moved inside, too, since, even if it doesn't render, the user won't notice

@Parkreiner Parkreiner requested a review from jaaydenh September 13, 2024 15:56
@Parkreiner
Copy link
Member Author

@jaaydenh Got the stories fixed, and went ahead and split the current quota story into two – one with the orgs feature, and one without

Copy link
Contributor

@jaaydenh jaaydenh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Parkreiner Parkreiner merged commit 9102256 into main Sep 16, 2024
27 checks passed
@Parkreiner Parkreiner deleted the mes/filter-work-1 branch September 16, 2024 20:17
@github-actions github-actions bot locked and limited conversation to collaborators Sep 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants