Skip to content

fix(helm): use list instead of dict for tolerations #14604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 10, 2024
Merged

fix(helm): use list instead of dict for tolerations #14604

merged 1 commit into from
Sep 10, 2024

Conversation

anakaiti
Copy link
Contributor

@anakaiti anakaiti commented Sep 9, 2024

Fixes #14603

@cdr-bot cdr-bot bot added the community Pull Requests and issues created by the community. label Sep 9, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 9, 2024 •
edited
Loading

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@anakaiti
Copy link
Contributor Author

anakaiti commented Sep 9, 2024

I have read the CLA Document and I hereby sign the CLA

cdrcommunity added a commit to coder/cla that referenced this pull request Sep 9, 2024
@cdrcommunity
@anakaiti has signed the CLA in coder/coder#14604
6c5886f
@matifali matifali requested a review from ericpaulsen September 9, 2024 10:45
ericpaulsen
ericpaulsen approved these changes Sep 9, 2024
View reviewed changes
Copy link
Member

@ericpaulsen ericpaulsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix!

@sreya sreya merged commit d1db11a into coder:main Sep 10, 2024
26 of 27 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sreya sreya sreya approved these changes

@ericpaulsen ericpaulsen ericpaulsen approved these changes

Assignees

@anakaiti anakaiti

Labels
community Pull Requests and issues created by the community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Helm chart: tolerations node kind is wrong in values.yaml
3 participants
@anakaiti @sreya @ericpaulsen