Skip to content

feat: expose current agent connections by type via prometheus #14612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

ethanndickson
Copy link
Member

@ethanndickson ethanndickson commented Sep 9, 2024

Closes #14357.

Adds a new prometheus metric coderd_agentstats_currently_reachable_peers that includes the current number of pingable peers. The label connection_type can currently be either derp or p2p.

For example:

coderd_agentstats_currently_reachable_peers{
    agent_name="main",
    connection_type="derp",
    template_name="docker",
    username="admin",
    workspace_name="workspace1"
} 1

Reflects that the agent main on the workspace workspace1 using the docker template has one peer, and that peer is connected over DERP.

Additionally, updates the documentation to make it clear that --prometheus-collect-agent-stats must be set for these agentstats metrics to be exposed on coderd.

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @ethanndickson and the rest of your teammates on Graphite Graphite

@ethanndickson ethanndickson force-pushed the 09-09-feat_expose_current_agent_connections_by_type_via_prometheus branch from ab2a5aa to e00c2e5 Compare September 9, 2024 11:30
@ethanndickson ethanndickson marked this pull request as ready for review September 9, 2024 11:34
@ethanndickson ethanndickson force-pushed the 09-09-feat_expose_current_agent_connections_by_type_via_prometheus branch from e00c2e5 to fcd1392 Compare September 10, 2024 04:11
@ethanndickson ethanndickson force-pushed the 09-09-feat_expose_current_agent_connections_by_type_via_prometheus branch from fcd1392 to 5c154ea Compare September 10, 2024 11:41
@ethanndickson ethanndickson merged commit c8580a4 into main Sep 11, 2024
37 checks passed
@ethanndickson ethanndickson deleted the 09-09-feat_expose_current_agent_connections_by_type_via_prometheus branch September 11, 2024 04:13
@github-actions github-actions bot locked and limited conversation to collaborators Sep 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prometheus metric on p2p versus DERP connections
3 participants