feat: add groups column to members page in organizations #14620
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aslilac
requested changes
Sep 10, 2024
| @@ -22,6 +23,8 @@ const OrganizationMembersPage: FC = () => { | |||
| }; | |||
| const { user: me } = useAuthenticated(); | |||
|
|
|||
| const groupsByUserIdQuery = useQuery(groupsByUserId()); | |||
There was a problem hiding this comment.
note how this query doesn't take the organizationName as a parameter: this is not scoped to an organization, this shows every group a user is in.
There was a problem hiding this comment.
Oops 🤦♀️ Thank you for catching that
BrunoQuaresma
approved these changes
Sep 10, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14315
This adds a 'Groups' column to the table on the
organizations/<name>/memberspage.Before change
After change