Skip to content

feat: implement runtime configuration package with multi-org support #14624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
Sep 9, 2024

Conversation

Emyrk
Copy link
Member

@Emyrk Emyrk commented Sep 9, 2024

A trimmed version of #14470

Removes DeploymentEntry and does not try to work with startup values.
This PR only handles runtime config values.

This is an attempt to get some code merged for use, since the DeploymentValue overrides are not needed at this very moment.

See original PR #14470 for more info.

dannykopping and others added 20 commits September 6, 2024 10:19
Signed-off-by: Danny Kopping <danny@coder.com>
Signed-off-by: Danny Kopping <danny@coder.com>
Signed-off-by: Danny Kopping <danny@coder.com>
Signed-off-by: Danny Kopping <danny@coder.com>
Signed-off-by: Danny Kopping <danny@coder.com>
Signed-off-by: Danny Kopping <danny@coder.com>
Signed-off-by: Danny Kopping <danny@coder.com>
Signed-off-by: Danny Kopping <danny@coder.com>
Signed-off-by: Danny Kopping <danny@coder.com>
* chore: refactor entry into deployment and runtime

RuntimeEntry has no startup value, and omits functions required
to be serpent compatible.

Co-authored-by: Danny Kopping <danny@coder.com>

---------

Co-authored-by: Danny Kopping <danny@coder.com>
Copy link
Member

@johnstcn johnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving to unblock

Copy link
Contributor

@dannykopping dannykopping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Emyrk Emyrk merged commit cb9d40f into main Sep 9, 2024
26 checks passed
@Emyrk Emyrk deleted the stevenmasley/runtime-config-no-startup branch September 9, 2024 19:14
@github-actions github-actions bot locked and limited conversation to collaborators Sep 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants