Skip to content

chore: add help tooltips explaining provisioner types #14625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Sep 17, 2024
Merged

chore: add help tooltips explaining provisioner types #14625

merged 14 commits into from
Sep 17, 2024

Conversation

aslilac
Copy link
Member

@aslilac aslilac commented Sep 9, 2024

Closes #14442

@aslilac aslilac changed the base branch from main to provisioner-version-popups September 9, 2024 17:25
@aslilac aslilac changed the title Provisioner types chore: add help tooltips explaining provisioner types Sep 9, 2024
@github-actions github-actions bot added the stale This issue is like stale bread. label Sep 17, 2024
@aslilac aslilac marked this pull request as ready for review September 17, 2024 17:29
@Kira-Pilot Kira-Pilot removed the stale This issue is like stale bread. label Sep 17, 2024
Parkreiner
Parkreiner approved these changes Sep 17, 2024
View reviewed changes
Copy link
Member

@Parkreiner Parkreiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Base automatically changed from provisioner-version-popups to main September 17, 2024 21:06
@aslilac aslilac merged commit de3945c into main Sep 17, 2024
27 checks passed
@aslilac aslilac deleted the provisioner-types branch September 17, 2024 21:20
@github-actions github-actions bot locked and limited conversation to collaborators Sep 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Parkreiner Parkreiner Parkreiner approved these changes

@BrunoQuaresma BrunoQuaresma Awaiting requested review from BrunoQuaresma

Assignees

@aslilac aslilac

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ui(provisioners): polish ui for built-in and psk provisioners
3 participants
@aslilac @Parkreiner @Kira-Pilot