Skip to content

chore: add navigation test for workspace details page #14629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 16, 2024

Conversation

Parkreiner
Copy link
Member

Part 3/3 for #14435
Won't be merging in until all parts are approved.

Changes made

  • Updated test helpers and top-level app components to make it easy to mock out implementations for specific providers
  • Added test for WorkspacePage to ensure that page navigations from there to the main workspace page resolve properly and account for the organization name

Bonus

  • Cleaned up a ternary that wasn't needed

Notes

  • Really wanted to add tests for the workspace pages filter (since we don't have any yet), but getting that part of the code into a reproducible state for tests is going to be a doozy. I tried for a little bit but ended up giving up. Think it's better to punt that until we can work on finally work on cleaning up all the logic surrounding that part of the codebase

@Parkreiner Parkreiner added the site Area: frontend dashboard label Sep 10, 2024
@Parkreiner Parkreiner requested a review from jaaydenh September 10, 2024 04:57
@Parkreiner Parkreiner self-assigned this Sep 10, 2024
@Parkreiner Parkreiner changed the title chore: add tests for navigating from workspace details page to workspaces page chore: add navigation tests for workspace details page Sep 10, 2024
@Parkreiner Parkreiner changed the title chore: add navigation tests for workspace details page chore: add navigation test for workspace details page Sep 10, 2024
Copy link
Contributor

@jaaydenh jaaydenh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like the addition of the props for RequireAuth

LGTM

@Parkreiner Parkreiner merged commit 6dbfe06 into mes/filter-work-2 Sep 16, 2024
23 checks passed
@Parkreiner Parkreiner deleted the mes/filter-work-3 branch September 16, 2024 20:35
@github-actions github-actions bot locked and limited conversation to collaborators Sep 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
site Area: frontend dashboard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants