chore: remove legacy AgentIP address #14640
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @spikecurtis and the rest of your teammates on |
4f41732 to
bc16937
Compare
spikecurtis
commented
Sep 11, 2024
| @@ -11,8 +11,7 @@ import { | |||
| } from "../helpers"; | |||
| import { beforeCoderTest } from "../hooks"; | |||
|
|
|||
| // we no longer support versions prior to single tailnet: https://github.com/coder/coder/commit/d7cbdbd9c64ad26821e6b35834c59ecf85dcd9d4 | |||
| const clientVersion = "v0.27.0"; | |||
| const clientVersion = "v2.8.0"; | |||
There was a problem hiding this comment.
Theoretically, this should work with 2.7.0. I tried it and it doesn't work. Rather than try to debug, I just set it to 2.8.0, which is what it'll be in the PR above this one on the stack.
bc16937 to
46730d8
Compare
deansheather
approved these changes
Sep 11, 2024
Merge activity
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the support for the Agent's "legacy IP" which was a hardcoded IP address all agents used to use, before we introduced "single tailnet". Single tailnet went GA in 2.7.0.