chore: read template tar from stdin if stdin is not a tty #14643
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13203.
coder templates push
currently only reads the template tar fromstdin
if the--directory
flag is set to-
. This is kind of awkward, and as seen in the attached issue, easy to miss. We can already check if the command is being piped to, so this is just a minor QOL improvement.This breaks one valid albeit odd workflow, where a confirmation is piped into the command instead of using
--yes/-y
:e.g:
would no longer work as expected.
Also updates
isTTY
toisTTYIn
, since the name suggests it could check eitherstdin
orstdout
, but it only checksstdin
, andisTTYOut
already exists.