feat: implement organization role sync #14649
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
96e4835 to
d7e2ac0
Compare
d7e2ac0 to
12c7af7
Compare
f0ssel
approved these changes
Sep 16, 2024
Comment on lines
+220
to
+225
| s.Logger.Debug(ctx, "OIDC roles ignored in assignment", | ||
| slog.F("ignored", ignored), | ||
| slog.F("assigned", filtered), | ||
| slog.F("user_id", user.ID), | ||
| slog.F("username", user.Username), | ||
| ) |
coderd/members.go
Outdated
| @@ -215,6 +216,33 @@ func (api *API) putMemberRoles(rw http.ResponseWriter, r *http.Request) { | |||
| aReq.Old = member.OrganizationMember.Auditable(member.Username) | |||
| defer commitAudit() | |||
|
|
|||
| // Keep this block scoping to prevent accidental use of the user variable. | |||
There was a problem hiding this comment.
This is basically saying this should be a function imo
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this does
Existing deployment values configure site role sync. Organizations can now configure org role sync.
Removed existing role sync, and moved all code to
idpsyncpackage.In support of #14203