Skip to content

fix: add type-safety for Storybook preview.jsx config file #14671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 13, 2024
Merged

fix: add type-safety for Storybook preview.jsx config file #14671

merged 3 commits into from
Sep 13, 2024

Conversation

Parkreiner
Copy link
Member

No issue to link – just something I noticed when working on a separate issue

Changes made

  • Added @ts-check directive and type-safe JSDoc comments to all components in our preview.jsx file
  • Fixed broken imports in the file (that weren't getting caught because we had no type-safety)
  • Formatted the file, and applied a few recommendations from the Biome linter

@Parkreiner Parkreiner requested review from a team and BrunoQuaresma and removed request for a team September 13, 2024 16:58
@Parkreiner Parkreiner self-assigned this Sep 13, 2024
BrunoQuaresma
BrunoQuaresma approved these changes Sep 13, 2024
View reviewed changes
Copy link
Collaborator

@BrunoQuaresma BrunoQuaresma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ty for making this

@Parkreiner Parkreiner merged commit 7ea8a22 into main Sep 13, 2024
27 checks passed
@Parkreiner Parkreiner deleted the mes/js-file-fix branch September 13, 2024 21:26
@github-actions github-actions bot locked and limited conversation to collaborators Sep 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@BrunoQuaresma BrunoQuaresma BrunoQuaresma approved these changes

Assignees

@Parkreiner Parkreiner

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Parkreiner @BrunoQuaresma