Skip to content

chore: add test for coord rolling restart #14680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 20, 2024

Conversation

deansheather
Copy link
Member

@github-actions github-actions bot added the stale This issue is like stale bread. label Oct 1, 2024
@github-actions github-actions bot closed this Oct 5, 2024
@sreya sreya reopened this Oct 14, 2024
@sreya sreya assigned ethanndickson and unassigned deansheather Oct 14, 2024
@github-actions github-actions bot removed the stale This issue is like stale bread. label Oct 15, 2024
@ethanndickson ethanndickson force-pushed the dean/coord-rolling-restart-test branch from a8c5708 to 75849b8 Compare October 18, 2024 06:43
@ethanndickson ethanndickson marked this pull request as ready for review October 18, 2024 06:53
@ethanndickson ethanndickson force-pushed the dean/coord-rolling-restart-test branch from bb4a87e to 63e03b5 Compare October 24, 2024 07:27
@github-actions github-actions bot added the stale This issue is like stale bread. label Nov 13, 2024
@github-actions github-actions bot closed this Nov 16, 2024
@sreya sreya reopened this Nov 18, 2024
@github-actions github-actions bot removed the stale This issue is like stale bread. label Nov 19, 2024
@ethanndickson ethanndickson force-pushed the dean/coord-rolling-restart-test branch from 84a6d82 to e454e42 Compare November 19, 2024 01:46
@ethanndickson
Copy link
Member

After a rebase on main, the test is now failing due to the dialer creating an error log while the server is down:

    t.go:115: 2024-11-19 01:50:26.405 [erro]  client: failed to dial tailnet v2+ API  error="failed to WebSocket dial: expected handshake response status code 101 but got 502" ...
        sdk_err= GET http://127.0.0.1:46789/api/v2/workspaceagents/54909b8e-b909-46fa-a33d-33afa7780731/coordinate?resume_token=*** unexpected status code 502: unexpected non-JSON response "text/plain; charset=utf-8"
                 	Error: server is not started
         *** slogtest: log detected at level ERROR; TEST FAILURE ***
    t.go:115: 2024-11-19 01:50:26.405 [erro]  client: failed to dial tailnet v2+ API  error="failed to WebSocket dial: expected handshake response status code 101 but got 502"
         *** slogtest: log detected at level ERROR; TEST FAILURE ***

@spikecurtis
Copy link
Contributor

After a rebase on main, the test is now failing due to the dialer creating an error log while the server is down:

    t.go:115: 2024-11-19 01:50:26.405 [erro]  client: failed to dial tailnet v2+ API  error="failed to WebSocket dial: expected handshake response status code 101 but got 502" ...
        sdk_err= GET http://127.0.0.1:46789/api/v2/workspaceagents/54909b8e-b909-46fa-a33d-33afa7780731/coordinate?resume_token=*** unexpected status code 502: unexpected non-JSON response "text/plain; charset=utf-8"
                 	Error: server is not started
         *** slogtest: log detected at level ERROR; TEST FAILURE ***
    t.go:115: 2024-11-19 01:50:26.405 [erro]  client: failed to dial tailnet v2+ API  error="failed to WebSocket dial: expected handshake response status code 101 but got 502"
         *** slogtest: log detected at level ERROR; TEST FAILURE ***

Those are real errors and we don't want to suppress them. You can configure the logger not to fail the test like

logger := slogtest.Make(t, &slogtest.Options{IgnoreErrors: true}).Level(slog.LevelDebug)

@ethanndickson
Copy link
Member

Okay, I think we can finally merge this?

@ethanndickson ethanndickson merged commit fbe2fa6 into main Nov 20, 2024
26 checks passed
@ethanndickson ethanndickson deleted the dean/coord-rolling-restart-test branch November 20, 2024 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add e2e test for client <-> agent reconnection
4 participants