Skip to content

fix(coderd): check if timings can be read #14697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 17, 2024
Merged

fix(coderd): check if timings can be read #14697

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f2eb072
fix(coderd): check if timings can be read
BrunoQuaresma Sep 17, 2024
a9b2976
Try to fix dbauthz test
BrunoQuaresma Sep 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix(coderd): check if timings can be read
  • Loading branch information
@BrunoQuaresma
BrunoQuaresma committed Sep 17, 2024
commit f2eb0723daa854baf70bb9619099403723bc8caa
4 changes: 4 additions & 0 deletions coderd/database/dbauthz/dbauthz.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1792,6 +1792,10 @@ func (q *querier) GetProvisionerJobByID(ctx context.Context, id uuid.UUID) (data
}

func (q *querier) GetProvisionerJobTimingsByJobID(ctx context.Context, jobID uuid.UUID) ([]database.ProvisionerJobTiming, error) {
_, err := q.GetProvisionerJobByID(ctx, jobID)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This approach raised my eyebrow, and I was going to suggest not doing it this way but I see we have precedent for this in GetProvisionerJobByID itself. Please add a comment explaining this.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sure we use a similar pattern for workspace builds or templates.

if err != nil {
return nil, err
}
return q.db.GetProvisionerJobTimingsByJobID(ctx, jobID)
}

Expand Down
Loading