Skip to content

fix: use floats in report template #14714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 18, 2024
Merged

fix: use floats in report template #14714

merged 3 commits into from
Sep 18, 2024

Conversation

mtojek
Copy link
Member

@mtojek mtojek commented Sep 18, 2024 •
edited
Loading

Related: #14571

This PR modifies the template body of email report to be float friendly, as json.Unmarshal unmarshals numbers in map[string]any to float64.

This is addressing:

 - template: text:7:81: executing "text" at <gt $version.failed_count 1>: error calling gt: incompatible types for comparison

@mtojek mtojek self-assigned this Sep 18, 2024
@mtojek mtojek added the hotfix label Sep 18, 2024
cdr-bot[bot]
cdr-bot bot approved these changes Sep 18, 2024
View reviewed changes
Copy link

@cdr-bot cdr-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is a hotfix and has been automatically approved.

  • ✅ Base is main or release branch
  • ✅ Has hotfix label
  • ✅ Head is from coder/coder
  • ✅ Less than 100 lines

@mtojek mtojek changed the title fix: report template uses floats fix: use floats in report template Sep 18, 2024
@mtojek mtojek marked this pull request as ready for review September 18, 2024 11:03
@mtojek mtojek enabled auto-merge (squash) September 18, 2024 11:24
@mtojek mtojek merged commit 20a3801 into main Sep 18, 2024
26 checks passed
@mtojek mtojek deleted the 40-report-floats branch September 18, 2024 11:26
@github-actions github-actions bot locked and limited conversation to collaborators Sep 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cdr-bot cdr-bot[bot] cdr-bot[bot] approved these changes

Assignees

@mtojek mtojek

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mtojek