Skip to content

feat: remove org flag requirement for provisioners #14722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 20, 2024

Conversation

f0ssel
Copy link
Contributor

@f0ssel f0ssel commented Sep 18, 2024

Closes #14188

What this changes:

  • You can no longer pass the org flag when using psk or key flags, since these auth methods dictate the org themselves
  • When authenticating with a psk or provisioner key we always use the default org which is ignored by the middleware and relies on the key providing the org.
  • Providing a PSK will now make the PSK auth take priority over user auth
  • You can only use the PSK for the default org now.
  • --psk flag has been marked deprecated in favor of --key

Some of these changes are breaking but only to org related options that are behind the experiment.

@f0ssel f0ssel changed the title feat: no longer require org flag for provisioners feat: remove org flag requirement for provisioners Sep 19, 2024
@f0ssel f0ssel marked this pull request as ready for review September 19, 2024 15:36
@f0ssel f0ssel requested a review from deansheather September 19, 2024 18:03
@f0ssel f0ssel merged commit 50124fe into main Sep 20, 2024
26 checks passed
@f0ssel f0ssel deleted the f0ssel/provisioner-no-org branch September 20, 2024 16:45
@github-actions github-actions bot locked and limited conversation to collaborators Sep 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Organization Provisioner Daemons API GA
2 participants