Skip to content

feat: add 'display_name' column to 'workspace_agent_scripts' #14747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 20, 2024
Merged

feat: add 'display_name' column to 'workspace_agent_scripts' #14747

merged 3 commits into from
Sep 20, 2024

Conversation

DanielleMaywood
Copy link
Contributor

@DanielleMaywood DanielleMaywood commented Sep 20, 2024 •
edited
Loading

Add a display_name column to workspace_agent_scripts table.

display_name is sourced from coder_script resource in the coder terraform provider. It will be used in the UI when we display script timings.

Work on #14713 requires display_name to be present in the database.

@DanielleMaywood DanielleMaywood marked this pull request as ready for review September 20, 2024 12:45
dannykopping
dannykopping approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@dannykopping dannykopping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Would you mind adding some more detail to the description about where this value comes from, and how it will be used?

@DanielleMaywood
Copy link
Contributor Author

Would you mind adding some more detail to the description about where this value comes from, and how it will be used?

Done! Let me know if you want more detail.

@dannykopping
Copy link
Contributor

Perfect, thanks 👍

@dannykopping
Copy link
Contributor

@DanielleMaywood should we wait for the other PR to be merged first?

@DanielleMaywood
Copy link
Contributor Author

I think this PR should go first as this is to pull out the display_name change from that one into a separate PR.

johnstcn
johnstcn approved these changes Sep 20, 2024
View reviewed changes
Copy link
Member

@johnstcn johnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@DanielleMaywood DanielleMaywood merged commit 86f68b2 into main Sep 20, 2024
39 checks passed
@DanielleMaywood DanielleMaywood deleted the dm-add-display-name-to-script-table branch September 20, 2024 13:26
@github-actions github-actions bot locked and limited conversation to collaborators Sep 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dannykopping dannykopping dannykopping approved these changes

@johnstcn johnstcn johnstcn approved these changes

Assignees

@DanielleMaywood DanielleMaywood

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DanielleMaywood @dannykopping @johnstcn