Skip to content

feat: add cache abstraction for fetching signing keys #14777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Oct 1, 2024
Merged

feat: add cache abstraction for fetching signing keys #14777

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
c6fdfe6
feat: add keychain abstraction for fetching rotated keys
sreya Sep 26, 2024
f9bff68
Refactor DBKeyCache to DBCache with clock support
sreya Sep 26, 2024
46503b6
Refactor CryptoKey handling to use codersdk package
sreya Sep 26, 2024
c63020a
Refactor CryptoKey conversion to use db2sdk package
sreya Sep 26, 2024
3e723ce
make gen
sreya Sep 26, 2024
201347f
Refactor key verification with db2sdk conversion
sreya Sep 26, 2024
5f9744b
pr comments
sreya Sep 29, 2024
5803092
Refactor error message for key fetching
sreya Sep 30, 2024
ea659b0
Refactor DBKeyCache with robust invalidation timing
sreya Oct 1, 2024
fe0b4e4
Add leak detection to dbkeycache tests
sreya Oct 1, 2024
430e1c2
Add mutex lock to DBCache Close method
sreya Oct 1, 2024
4dfdd4f
Add closed state to DBCache for safe shutdown
sreya Oct 1, 2024
5078c2a
Optimize timer reset in fetch method
sreya Oct 1, 2024
280d521
Refactor DBCache to remove unused timer function
sreya Oct 1, 2024
05dec8a
finale
sreya Oct 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
finale
  • Loading branch information
@sreya
sreya committed Oct 1, 2024
commit 05dec8a8cc3a3e39bca42f77306abfcdf2bcdc0b
8 changes: 8 additions & 0 deletions coderd/cryptokeys/dbkeycache.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,10 @@ func (d *DBCache) Verifying(ctx context.Context, sequence int32) (codersdk.Crypt
d.keysMu.Lock()
defer d.keysMu.Unlock()

if d.closed {
return codersdk.CryptoKey{}, ErrClosed
}

key, ok = d.keys[sequence]
if ok {
return checkKey(key, now)
Expand Down Expand Up @@ -120,6 +124,10 @@ func (d *DBCache) Signing(ctx context.Context) (codersdk.CryptoKey, error) {
d.keysMu.Lock()
defer d.keysMu.Unlock()

if d.closed {
return codersdk.CryptoKey{}, ErrClosed
}

if d.latestKey.CanSign(now) {
return db2sdk.CryptoKey(d.latestKey), nil
}
Expand Down
Loading