feat: Add SSH Keys page on /preferences/ssh-keys #1478
Conversation
| | { type: "GET_SSH_KEY" } | ||
| | { type: "REGENERATE_SSH_KEY" } | ||
| | { type: "CONFIRM_REGENERATE_SSH_KEY" } | ||
| | { type: "CANCEL_REGENERATE_SSH_KEY" } |
There was a problem hiding this comment.
Should we rename this UserEvent instead? Seems like it's more accurate.
|
@kylecarbs Right now the page is called "Preferences" so I think makes more sense to keep using "preferences" than "settings". Settings is something more related to an "account" than a "user" thing, makes sense? And about the event type being UserEvent makes sense but I would like to keep using the implicit convention we are using to name the event as {ServiceName}Event. I have no strong opinion tho. Please let me know what you think so I can make or not the changes. |
|
GitHub and GitLab both use the term settings, which is my primary reason for preferring that. Just because it's already called preferences doesn't necessarily mean it's right! It's an easy enough change, so if we feel it's clearer to the user, we should make it. |
|
Hm.. interesting. Working on it! |
Closes #752 and #749