Skip to content

chore: add db query to retrieve workspaces & their agents #14792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 1, 2024
Merged

chore: add db query to retrieve workspaces & their agents #14792

merged 5 commits into from
Nov 1, 2024

Conversation

ethanndickson
Copy link
Member

@ethanndickson ethanndickson commented Sep 25, 2024 •
edited
Loading

Second PR for #14716.

Adds a query that, given a user ID, returns all the workspaces they own, that can also be ActionRead by the requesting user.

type GetWorkspacesAndAgentsByOwnerIDRow struct {
	WorkspaceID      uuid.UUID            `db:"workspace_id" json:"workspace_id"`
	WorkspaceName    string               `db:"workspace_name" json:"workspace_name"`
	JobStatus        ProvisionerJobStatus `db:"job_status" json:"job_status"`
	Transition       WorkspaceTransition  `db:"transition" json:"transition"`
	Agents           []AgentIDNamePair    `db:"agents" json:"agents"`
}

JobStatus and Transition are set using the latest build/job of the workspace. Deleted workspaces are not included.

@ethanndickson Graphite App
Copy link
Member Author

ethanndickson commented Sep 25, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @ethanndickson and the rest of your teammates on Graphite Graphite

@ethanndickson ethanndickson marked this pull request as ready for review September 25, 2024 07:46
spikecurtis
spikecurtis reviewed Sep 25, 2024
View reviewed changes
@ethanndickson ethanndickson force-pushed the 09-25-chore_add_db_query_to_retrieve_workspaces_their_agents branch 3 times, most recently from 6e44f26 to 97ac5bc Compare September 26, 2024 08:28
ethanndickson
ethanndickson commented Sep 26, 2024
View reviewed changes
coderd/database/sqlc.yaml
@@ -28,6 +28,9 @@ sql:
emit_enum_valid_method: true
emit_all_enum_values: true
overrides:
- db_type: "agent_name_pair"
go_type:
type: "AgentIDNamePair"
Copy link
Member Author

@ethanndickson ethanndickson Sep 26, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Required due to sqlc-dev/sqlc#2760

@ethanndickson ethanndickson force-pushed the 09-25-chore_add_db_query_to_retrieve_workspaces_their_agents branch 3 times, most recently from aacd023 to 22985f7 Compare September 27, 2024 05:11
@ethanndickson ethanndickson mentioned this pull request Sep 27, 2024
Merged
@ethanndickson ethanndickson force-pushed the 09-25-chore_add_db_query_to_retrieve_workspaces_their_agents branch 2 times, most recently from db04bcf to 50f874c Compare September 30, 2024 09:35
deansheather
deansheather reviewed Sep 30, 2024
View reviewed changes
@ethanndickson ethanndickson force-pushed the 09-25-chore_add_db_query_to_retrieve_workspaces_their_agents branch 5 times, most recently from 2bc6e69 to 54cbfaf Compare October 3, 2024 15:07
@alwaysmeticulous alwaysmeticulous
Copy link

Meticulous was unable to execute a test run for this PR because the most recent commit is associated with multiple PRs. To execute a test run, please try pushing up a new commit that is only associated with this PR.

Last updated for commit 701c1b6. This comment will update as new commits are pushed.

@ethanndickson ethanndickson changed the base branch from main to ethan/owner-pubsub October 3, 2024 15:07
@ethanndickson ethanndickson mentioned this pull request Oct 3, 2024
Merged
@ethanndickson ethanndickson marked this pull request as draft October 3, 2024 15:35
@ethanndickson ethanndickson force-pushed the 09-25-chore_add_db_query_to_retrieve_workspaces_their_agents branch from 54cbfaf to aad36cf Compare October 4, 2024 03:45
@ethanndickson ethanndickson force-pushed the 09-25-chore_add_db_query_to_retrieve_workspaces_their_agents branch from aad36cf to b5f7529 Compare October 4, 2024 05:51
@ethanndickson ethanndickson force-pushed the 09-25-chore_add_db_query_to_retrieve_workspaces_their_agents branch from aafb31a to 21fa63c Compare October 22, 2024 10:04
@ethanndickson ethanndickson force-pushed the 09-25-chore_add_db_query_to_retrieve_workspaces_their_agents branch 2 times, most recently from cfa32d5 to 3a95c19 Compare October 24, 2024 04:41
@ethanndickson ethanndickson force-pushed the 09-25-chore_add_db_query_to_retrieve_workspaces_their_agents branch from 3a95c19 to 22db890 Compare October 28, 2024 12:04
@ethanndickson ethanndickson force-pushed the 09-25-chore_add_db_query_to_retrieve_workspaces_their_agents branch from 22db890 to c55e54b Compare October 28, 2024 15:23
@ethanndickson ethanndickson force-pushed the 09-25-chore_add_db_query_to_retrieve_workspaces_their_agents branch from c55e54b to 45225e4 Compare October 29, 2024 03:14
spikecurtis
spikecurtis requested changes Oct 29, 2024
View reviewed changes
@ethanndickson ethanndickson force-pushed the 09-25-chore_add_db_query_to_retrieve_workspaces_their_agents branch from e05b286 to a45a43c Compare October 29, 2024 09:53
@ethanndickson ethanndickson force-pushed the 09-25-chore_add_db_query_to_retrieve_workspaces_their_agents branch from a45a43c to 744633f Compare November 1, 2024 03:02
@ethanndickson ethanndickson changed the base branch from ethan/owner-pubsub to graphite-base/14792 November 1, 2024 03:17
@ethanndickson ethanndickson force-pushed the 09-25-chore_add_db_query_to_retrieve_workspaces_their_agents branch from 744633f to 54ceea2 Compare November 1, 2024 03:17
@ethanndickson ethanndickson changed the base branch from graphite-base/14792 to main November 1, 2024 03:18
@ethanndickson ethanndickson force-pushed the 09-25-chore_add_db_query_to_retrieve_workspaces_their_agents branch from 54ceea2 to 8be52ed Compare November 1, 2024 03:18
@ethanndickson ethanndickson merged commit f941e78 into main Nov 1, 2024
27 checks passed
@ethanndickson ethanndickson deleted the 09-25-chore_add_db_query_to_retrieve_workspaces_their_agents branch November 1, 2024 03:36
@github-actions github-actions bot locked and limited conversation to collaborators Nov 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@deansheather deansheather deansheather left review comments

@spikecurtis spikecurtis spikecurtis approved these changes

@sreya sreya Awaiting requested review from sreya

Assignees

@ethanndickson ethanndickson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ethanndickson @spikecurtis @deansheather @matifali