Skip to content

fix(envbuilder-dogfood): configure provider correctly #14796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 25, 2024
Merged

fix(envbuilder-dogfood): configure provider correctly #14796

merged 2 commits into from
Sep 25, 2024

Conversation

johnstcn
Copy link
Member

Forgot to pass in the docker config path to the provider! This means that it's unable to fetch a cached image from the repo.

@johnstcn johnstcn requested a review from mafredri September 25, 2024 13:46
@johnstcn johnstcn self-assigned this Sep 25, 2024
mafredri
mafredri approved these changes Sep 25, 2024
View reviewed changes
Copy link
Member

@mafredri mafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👨🏻‍🍳

@johnstcn johnstcn mentioned this pull request Sep 25, 2024
Closed
@johnstcn johnstcn merged commit bb3850a into main Sep 25, 2024
23 checks passed
@johnstcn johnstcn deleted the cj/envbuilder-dogfood-dockerconfigjson-path-var branch September 25, 2024 16:14
@github-actions github-actions bot locked and limited conversation to collaborators Sep 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mafredri mafredri mafredri approved these changes

Assignees

@johnstcn johnstcn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johnstcn @mafredri