docs: enable Slack notifications #14830
Conversation
There was a problem hiding this comment.
Overall looks great!
I think @EdwardAngert should have a look as well, if possible.
Thanks for putting this together!
| receiver.router.post("/webhook", async (req, res) => { | ||
| try { | ||
| if (!req.body) { | ||
| return res.status(400).send("Error: request body is missing"); |
There was a problem hiding this comment.
If we fail the webhook receiver, the webhook will be retried.
In this case, I think we should just log but let the receiver return successfully.
There was a problem hiding this comment.
You're right, but I'd like to keep the logic short. TBH I wanted to remove the HTTP request entity validation at all to indicate the communication flow with Slack API.
Also, this is rather a prevention mechanism for potential internet crawlers or scanners trying to send crappy requests.
There was a problem hiding this comment.
I think we can still demonstrate the correct behaviour, but it's not a big deal.
Also, this is rather a prevention mechanism for potential internet crawlers or scanners trying to send crappy requests.
By that logic, shouldn't the requests succeed so the crawlers don't know their request was invalid?
There was a problem hiding this comment.
By that logic, shouldn't the requests succeed so the crawlers don't know their request was invalid?
That's a long story; frankly, it depends on the crawler implementation, and HTTP200 may encourage them to perform further scans :)
I'll defer to platform admins to take a decision on this 👍 .
| receiver.router.post("/webhook", async (req, res) => { | ||
| try { | ||
| if (!req.body) { | ||
| return res.status(400).send("Error: request body is missing"); |
There was a problem hiding this comment.
I think we can still demonstrate the correct behaviour, but it's not a big deal.
Also, this is rather a prevention mechanism for potential internet crawlers or scanners trying to send crappy requests.
By that logic, shouldn't the requests succeed so the crawlers don't know their request was invalid?
Fixes: #14740
Preview: link
This PR adds a subpage to Coder docs with a guide on integrating Coder with MS Teams notifications.