Skip to content

feat: add WorkspaceUpdates tailnet RPC #14847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Nov 1, 2024
Merged

feat: add WorkspaceUpdates tailnet RPC #14847

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
6de5ce2
feat: add WorkspaceUpdates rpc
ethanndickson Sep 27, 2024
341c688
review p1
ethanndickson Oct 22, 2024
8cff11b
review p2
ethanndickson Oct 23, 2024
eafee6b
remove mutex on sub close
ethanndickson Oct 23, 2024
8195b93
remove sql no rows
ethanndickson Oct 23, 2024
4ef174a
rbac filter
ethanndickson Oct 23, 2024
b509099
review
ethanndickson Oct 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove mutex on sub close
  • Loading branch information
@ethanndickson
ethanndickson committed Nov 1, 2024
commit eafee6b5b00fa13fc5a792db6f2bc5abfa3f8520
2 changes: 0 additions & 2 deletions coderd/workspaceupdates.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,8 +110,6 @@ func (s *sub) start(ctx context.Context) (err error) {
func (s *sub) Close() error {
s.cancelFn()

Copy link
Member Author

@ethanndickson ethanndickson Oct 23, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cancelFn and psCancelFn aren't read from or written to once this Close function could ever be called, and the channel won't be read on after cancelFn cancels the context, so we don't need to acquire the mutex here. We'll also assume calling Close multiple times is undefined.

s.mu.Lock()
defer s.mu.Unlock()
if s.psCancelFn != nil {
s.psCancelFn()
}
Expand Down